Implement basic support for rest.sigv4_enabled for the Iceberg REST catalog
#917
+584
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2025
|
I found this PR while digging into how to query AWS' REST catalog implementation for S3 Tables. |
Contributor
Author
I think we might need to rework this to not depend on the aws crates for the signing part - that seems to have some conflicts I wasn't able to resolve with the MSRV check. Looking at how the object_store crate does it would be a good start: https://github.com/apache/arrow-rs-object-store/blob/main/src/aws/credential.rs |
This was referenced May 1, 2025
Contributor
Author
|
Closing because #1241 should be the preferred approach. |
sgrebnov
pushed a commit
to spiceai/iceberg-rust
that referenced
this pull request
Sep 25, 2025
Original change: #1 Upstream PR: apache#917
peasee
pushed a commit
to spiceai/iceberg-rust
that referenced
this pull request
Oct 27, 2025
Original change: #1 Upstream PR: apache#917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements basic support for connecting to the AWS Glue Iceberg REST catalog by supporting the parameters
rest.sigv4-enabled,rest.signing-nameandrest.signing-region. See the corresponding parameters in the PyIceberg docs: https://py.iceberg.apache.org/configuration/#rest-catalogI've added a new feature to the
iceberg-catalog-restcalledsigv4which when enabled, will recognize the above configuration parameters. I've left this disabled by default.I added the crate
request_middlewareto allow running middleware on requests, and if therest.sigv4-enabledconfiguration is enabled, the middleware to sign the request and add the correctAuthorizationheader is enabled.I've tested this implementation in my project, and it works great for connecting to the AWS Glue REST catalog, i.e.
https://glue.<region>.amazonaws.com/icebergI based this logic on the equivalent logic in PyIceberg: https://github.com/apache/iceberg-python/blob/6fffb644518bb64e8f33883d850edbe18c12bd07/pyiceberg/catalog/rest.py#L475