Core, Release: 1.9.0 Build Version() returns Unspecified due to incorrect packaged iceberg-build.properties

[sullis]

Apache Iceberg version

1.9.0 (latest release)

Query engine

None

Please describe the bug 🐞

Apache Iceberg 1.9.0 (java library)

iceberg-api-1.9.0.jar contains iceberg-build.properties

The contents of iceberg-build.properties is incorrect

$ cat iceberg-build.properties 

Output:

git.branch=1.9.x
git.build.version=unspecified
git.closest.tag.name=apache-iceberg-1.9.0-rc2
git.commit.id=7dbafb438ee1e68d0047bebcb587265d7d87d8a1
git.commit.id.abbrev=7dbafb4
git.commit.message.short=API\: Don't check underlying error msg on AIOOBE (\#12867)
git.commit.time=2025-04-22T15\:14\:07+0200
git.tags=apache-iceberg-1.9.0-rc2

🏓 "git.build.version" should be "1.9.0"

Willingness to contribute

• I can contribute a fix for this bug independently
• I would be willing to contribute a fix for this bug with guidance from the Iceberg community
• I cannot contribute a fix for this bug at this time

[ajantha-bhat]

@nastra : Do we have guidelines in publishing this jar? I think it was automated script that we use all the time.

[nastra]

the git.build.version is generated by the git plugin that we use (com.gorylenko.gradle-git-properties) but I don't recall how it determines the build version (you might want to check https://github.com/n0mer/gradle-git-properties/blob/master/src/main/groovy/com/gorylenko/GitProperties.groovy). We can also omit git.build.version if it causes confusion for people or override it with the projectVersion if possible

[sullis]

For clarification:

• I have a Java application that calls the version() method in org.apache.iceberg.IcebergBuild

• In Iceberg 1.9.0, the version() method returns "unspecified"

[RussellSpitzer]

That's definitely a bug, although i'm not sure it's ever not been broken. Let me do a quick check

1.7.0 --

scala> import org.apache.iceberg.IcebergBuild
import org.apache.iceberg.IcebergBuild

scala> IcebergBuild.version()
res0: String = 1.7.0

1.8.0 --

scala> import org.apache.iceberg.IcebergBuild
import org.apache.iceberg.IcebergBuild

scala> IcebergBuild.version()
res0: String = 1.8.0

1.9.0 --

scala> import org.apache.iceberg.IcebergBuild
import org.apache.iceberg.IcebergBuild

scala> IcebergBuild.version()
res0: String = unspecified

[sullis]

That's definitely a bug, although i'm not sure it's ever not been broken. Let me do a quick check

My Java app works fine with prior versions of the library: (1.6.1, 1.7.0, 1.8.0, 1.8.1)

Version 1.9.0 is the first release where I am seeing "unspecified"

[RussellSpitzer]

1.8.1 --

git.branch=1.8.x
git.build.version=1.8.1
git.closest.tag.name=apache-iceberg-1.8.1-rc1
git.commit.id=9ce0fcf0af7becf25ad9fc996c3bad2afdcfd33d
git.commit.id.abbrev=9ce0fcf
git.commit.message.short=[1.8.x] Fix versions in LICENSE/NOTICE (\#12365)
git.commit.time=2025-02-24T14\:14\:57+0100
git.tags=apache-iceberg-1.8.1-rc1

[RussellSpitzer]

➜  iceberg git:(apache-iceberg-1.9.0-rc1) ✗ rm build/iceberg-build.properties
➜  iceberg git:(apache-iceberg-1.9.0-rc1) ✗ ./gradlew generateGitProperties

Configuration on demand is an incubating feature.

[Incubating] Problems report is available at: file:///Users/rspitzer/repos/iceberg/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.13/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 1s
1 actionable task: 1 executed
➜  iceberg git:(apache-iceberg-1.9.0-rc1) ✗ cat build/iceberg-build.properties
git.branch=HEAD
git.build.version=unspecified
git.closest.tag.name=apache-iceberg-1.9.0-rc1
git.commit.id=9fc49e187069c7ec2493ac0abf20f73175b3df89
git.commit.id.abbrev=9fc49e1
git.commit.message.short=AWS, Azure, Kafka\: Fix versions in LICENSE and NOTICE (\#12831)
git.commit.time=2025-04-17T09\:28\:37-0500
git.tags=apache-iceberg-1.9.0-rc1

[RussellSpitzer]

Ok caused by a bump to Gradle-git-properties
456bbe9

Which seems to do some new fun groovy things like redefining our version function here
n0mer/gradle-git-properties@9f5c89e

Looking into fixing this

[RussellSpitzer]

I have a fix, just working on some automated tests to catch if we have a source release that would not produce the correct version