Remove some dead code, fill some javadocs #10530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Jun 18, 2024
...v1.18/flink/src/main/java/org/apache/iceberg/flink/source/enumerator/EnumerationHistory.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jun 18, 2024
...v1.17/flink/src/main/java/org/apache/iceberg/flink/source/enumerator/EnumerationHistory.java
Outdated
Show resolved
Hide resolved
The javadoc summary is expected by error-prone's `MissingSummary` check. Apparently the error-prone version currently in use could not find these, but a newer version can.
nastra
approved these changes
Jun 18, 2024
|
thank you @nastra @amogh-jahagirdar for your review! |
jasonf20
pushed a commit
to jasonf20/iceberg
that referenced
this pull request
Aug 4, 2024
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by #10518