open-api: Fix compile warnings for testFixtures

[ajantha-bhat]

./gradlew clean build -x test -x integrationTest --no-build-cache results in compile warnings for open-api module.

The reason is that new dependencies that are added in #10908 requires apigurdian during testFixtureCompilation.

+--- org.junit.jupiter:junit-jupiter:5.10.1 -> 5.10.3
|    +--- org.junit:junit-bom:5.10.3
|    |    +--- org.junit.jupiter:junit-jupiter:5.10.3 (c)
|    |    +--- org.junit.jupiter:junit-jupiter-engine:5.10.3 (c)
|    |    +--- org.junit.platform:junit-platform-commons:1.10.3 (c)
|    |    +--- org.junit.platform:junit-platform-engine:1.10.3 (c)
|    |    +--- org.junit.platform:junit-platform-suite-api:1.10.3 (c)
|    |    +--- org.junit.platform:junit-platform-suite-engine:1.10.3 (c)
|    |    +--- org.junit.jupiter:junit-jupiter-api:5.10.3 (c)
|    |    \--- org.junit.jupiter:junit-jupiter-params:5.10.3 (c)
|    +--- org.junit.jupiter:junit-jupiter-api:5.10.3
|    |    +--- org.junit:junit-bom:5.10.3 (*)
|    |    +--- org.opentest4j:opentest4j:1.3.0
|    |    +--- org.junit.platform:junit-platform-commons:1.10.3
|    |    |    +--- org.junit:junit-bom:5.10.3 (*)
|    |    |    \--- org.apiguardian:apiguardian-api:1.1.2
|    |    \--- org.apiguardian:apiguardian-api:1.1.2
|    \--- org.junit.jupiter:junit-jupiter-params:5.10.3
|         +--- org.junit:junit-bom:5.10.3 (*)
|         +--- org.junit.jupiter:junit-jupiter-api:5.10.3 (*)
|         \--- org.apiguardian:apiguardian-api:1.1.2
+--- org.junit.jupiter:junit-jupiter-engine:5.10.1 -> 5.10.3
|    +--- org.junit:junit-bom:5.10.3 (*)
|    +--- org.junit.platform:junit-platform-engine:1.10.3
|    |    +--- org.junit:junit-bom:5.10.3 (*)
|    |    +--- org.opentest4j:opentest4j:1.3.0
|    |    +--- org.junit.platform:junit-platform-commons:1.10.3 (*)
|    |    \--- org.apiguardian:apiguardian-api:1.1.2
|    +--- org.junit.jupiter:junit-jupiter-api:5.10.3 (*)
|    \--- org.apiguardian:apiguardian-api:1.1.2

[ajantha-bhat]

Apache licensed
https://github.com/apiguardian-team/apiguardian

[danielcweeks]

@ajantha-bhat Strange as it may seem, we can use exclusions and not add a new library:

    testImplementation(libs.junit.suite.api) {
      exclude group: 'org.junit.jupiter'
    }
    testImplementation(libs.junit.suite.engine) {
      exclude group: 'org.junit.jupiter'
    }

I think I'd prefer this over adding new libraries

[ajantha-bhat]

@danielcweeks: I tried excluding as you suggested and it didn't work. I also tried excluding just the exclude group: 'org.apiguardian', module: 'apiguardian-api' and it didn't work either.

The compile warnings is from Task :iceberg-open-api:compileTestFixturesJava. I checked the ./gradlew :iceberg-open-api:dependencies and couldn't find any dependencies that needs apiguardian for TestFixtures. So, I am assuming this dependency is needed by the plugin 'java-test-fixtures'?

I didn't find a way to fix these warnings without adding this compile time dependency. Feel free to try it out and let me know if there are other ways to handle this.

[danielcweeks]

@ajantha-bhat Yeah, you're right. I must have been running with a cache and it was hiding the errors.

The dependency is pulled in via the RESTServerExtention.java in testFixtures via these interfaces:

import org.junit.jupiter.api.extension.AfterAllCallback;
import org.junit.jupiter.api.extension.BeforeAllCallback;
import org.junit.jupiter.api.extension.ExtensionContext;

which in turn have the annotations:

@API(
  status = Status.STABLE,
  since = "5.0"
)

I think they had previously fixed this issue in JUnit, but it looks like it has crept back into the latest releases.