Create publish-docker.yml #11632
Create publish-docker.yml #11632
Conversation
|
I was waiting for the account creation. But thanks for working on it. |
|
in addition to pushing the latest, it would be great to publish images tagged with specific releases (1.7/1.8/etc) |
I think many of us are eager to get the docker image in the hub to improve our integration tests in the sub project repositories. Thank you for doing the hard work @ajantha-bhat ! |
Thanks for the suggestion @kevinjqliu - I've added a new trigger for tag push events to publish the docker images with the version tag |
There was a problem hiding this comment.
Ran it on my fork, and it looks good: https://github.com/Fokko/iceberg/actions/runs/12007773313
| run: | | ||
| docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{ secrets.DOCKERHUB_TOKEN }} | ||
| - name: Build Docker Image | ||
| run: docker build -t apache/iceberg-rest-adapter -f docker/iceberg-rest-adapter-image/Dockerfile . |
There was a problem hiding this comment.
What about using apache/iceberg-rest-fixture ? If we have a consensus, I can rename apache/iceberg.
There was a problem hiding this comment.
I am ok with the name iceberg-rest-fixture, it is a good name 👍
Pending completion of: https://github.com/apache/iceberg/pull/11283/files