Core: Propagate custom metrics reporter when table is created/replaced through Transaction #11671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d through Transaction
nastra
commented
Nov 28, 2024
|
|
||
| @Override | ||
| protected Map<String, String> properties() { | ||
| return catalogProperties == null ? ImmutableMap.of() : catalogProperties; |
Contributor
Author
There was a problem hiding this comment.
this is needed so that the metrics reporter is properly initialized
Contributor
There was a problem hiding this comment.
Thanks for fixing this!
3 tasks
nastra
force-pushed
the
metrics-reporting
branch
2 times, most recently
from
f2c2a9d to
a4d6004
Compare
nastra
force-pushed
the
metrics-reporting
branch
from
a4d6004 to
f3c736d
Compare
nastra
force-pushed
the
metrics-reporting
branch
from
f3c736d to
8219e0c
Compare
amogh-jahagirdar
approved these changes
Nov 28, 2024
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Thanks @nastra this looks great to me!
|
|
||
| @Override | ||
| protected Map<String, String> properties() { | ||
| return catalogProperties == null ? ImmutableMap.of() : catalogProperties; |
Contributor
There was a problem hiding this comment.
Thanks for fixing this!
Contributor
Author
|
thanks @jbonofre and @amogh-jahagirdar for the reviews |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
…d through Transaction (apache#11671)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11664