Spark 3.4: Add REST catalog to Spark integration tests #11698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Dec 4, 2024
| * This class is to make the {@link RESTCatalogServer} usable for JUnit4 in a similar way to {@link | ||
| * RESTServerExtension}. | ||
| */ | ||
| public class RESTServerRule extends ExternalResource { |
There was a problem hiding this comment.
this only exists in Spark so that we can run existing tests in Spark 3.4 (which are all still based on JUnit4)
nastra
force-pushed
the
spark34-rest-integration-tests-new
branch
2 times, most recently
from
18fdff9 to
1655438
Compare
nastra
force-pushed
the
spark34-rest-integration-tests-new
branch
from
1655438 to
3ac9b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #11093 to Spark 3.4 as this is required in order to be able to backport the tests to Spark 3.4 of #11388