API: Add missing deprecations #11734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-add-missing-deprecations
branch
from
1be0015 to
0e4ac9c
Compare
nastra
reviewed
Dec 9, 2024
| /** | ||
| * Instantiates a new Bucket Transform | ||
| * | ||
| * @deprecated use {@link #get(int)} instead; will be removed in 2.0.0 |
There was a problem hiding this comment.
minor: the deprecated msg is typically the other way around: will be removed in 2.0.0; use {@link #get(int)} instead
There was a problem hiding this comment.
Thanks, I think this how you typically structure a sentence in Dutch 😁
nastra
approved these changes
Dec 9, 2024
Adds some missing deprecations as based in apache#11691 Also, copied some deprecations from the interface to the implementations to make it more explicit.
Fokko
force-pushed
the
fd-add-missing-deprecations
branch
from
0e4ac9c to
a9324ab
Compare
ebyhr
approved these changes
Dec 10, 2024
api/src/main/java/org/apache/iceberg/transforms/UnknownTransform.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/apache/iceberg/transforms/VoidTransform.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some missing deprecations as based in #11691
Also, copied some deprecations from the interface to the implementations to make it more explicit.