Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExternalTypeInfo in Rowconverter code instead of deprecated TableSchema.getFieldTypes #11838

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abharath9
Copy link
Contributor

@abharath9 abharath9 commented Dec 20, 2024

  • I just discovered that the LegacyTypeInfoDataTypeConverter(used by tableSchema.getFieldTypes()) doesn't support Instant datatypes.
  • To work for Instant datatypes, we either change LegacyTypeInfoDataTypeConverter or use a different method. But the LegacyTypeInfoDataTypeConverter has been tagged deprecated.
  • So I found another way to convert DataType to TypeInfo and made changes. Please review.

Sorry, I should have dug a little more into this code earlier.

@abharath9
Copy link
Contributor Author

@stevenzwu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant