Skip to content

Conversation

@rominparekh
Copy link
Contributor

@rominparekh rominparekh commented Mar 4, 2019

Issue: #53

This PR:

  • Changes package name from com.netflix.iceberg to org.apache.iceberg
  • Java and Scala style formatting is not changed
  • I've tried my best to not remove any unused imports. If you find any missing and want to add it back, I'm happy to accommodate your feedback.
  • Changes made to gradle.build and TestSparkReadProjection files to detect change in packaging source respectively
  • I understand this impacts any in-flight PRs but I feel it's better to get this in sooner than later.

Reviewers, I request you to prioritize this change to avoid merge conflicts. Thank you. :)

cc: @rdblue , @vrozov , @xabriel , @prodeezy , @fbocse

@xabriel
Copy link
Contributor

xabriel commented Mar 5, 2019

@rominparekh #69 and #28 are open, and have similar goal: to rename Iceberg to apache packages, and to fix/start enforcing a coding standard.

@rominparekh
Copy link
Contributor Author

@xabriel thank you for sharing those PRs. I was not aware it was already covered. Closing this .

@rominparekh rominparekh closed this Mar 6, 2019
@rominparekh rominparekh deleted the package-name-change branch March 6, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants