Core: Pass storage credentials from LoadTableResponse to FileIO

[nastra]

No description provided.

[amogh-jahagirdar]

Thanks @nastra! Passing through the credentials to the fileIO implementations looks great. Just had a comment for adding a JavaDoc on the new mixin interface since it is public.

[nastra]

thanks for the reviews @amogh-jahagirdar and @danielcweeks

[tedyu]

From what I observe, the this.storageCredentials can be wrapped in ImmutableList.copyOf. This way, credentials() doesn't have to create a copy every time.

[nastra]

this will not work with Kryo ser/de because Kryo will try to add elements back after deserialization into the list and then fail

[tedyu]

I think the getter can be written this way (with additional field called copy):
first time getter assigns ImmutableList.copyOf() to copy field

subsequently copy field is returned directly until setter is called