Skip to content

Conversation

@wypoon
Copy link
Contributor

@wypoon wypoon commented May 19, 2025

Use the ReadLimit passed in to SparkMicroBatchStream::latestOffset(Offset, ReadLimit). In testing this, a bug was found in SparkMicroBatchStream::getDefaultReadLimit() and fixed.

This is a backport of #12260.

@github-actions github-actions bot added the spark label May 19, 2025
@wypoon wypoon force-pushed the ss_rate_limit_fix_34 branch from dc1b477 to f2ddb78 Compare May 20, 2025 00:42
@wypoon
Copy link
Contributor Author

wypoon commented May 20, 2025

cc @huaxingao @singhpk234
This is a clean backport.

Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvary pvary merged commit 6550486 into apache:main May 21, 2025
43 of 54 checks passed
@pvary
Copy link
Contributor

pvary commented May 21, 2025

Thanks for the backport @wypoon and @huaxingao for the review!

devendra-nr pushed a commit to devendra-nr/iceberg that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants