Skip to content

Return metrics from the Parquet footer after writing. #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 1 commit into from
Mar 24, 2019
Merged

Return metrics from the Parquet footer after writing. #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriteAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,19 @@
import org.apache.iceberg.exceptions.RuntimeIOException;
import org.apache.iceberg.io.FileAppender;
import org.apache.parquet.hadoop.ParquetWriter;
import org.apache.parquet.hadoop.metadata.ParquetMetadata;

public class ParquetWriteAdapter<D> implements FileAppender<D> {
private ParquetWriter<D> writer = null;
private long numRecords = 0L;
private ParquetMetadata footer = null;

public ParquetWriteAdapter(ParquetWriter<D> writer) throws IOException {
public ParquetWriteAdapter(ParquetWriter<D> writer) {
this.writer = writer;
}

@Override
public void add(D datum) {
try {
numRecords += 1L;
writer.write(datum);
} catch (IOException e) {
throw new RuntimeIOException(e, "Failed to write record %s", datum);
Expand All @@ -46,7 +46,8 @@ public void add(D datum) {

@Override
public Metrics metrics() {
return new Metrics(numRecords, null, null, null);
Preconditions.checkState(footer != null, "Cannot produce metrics until closed");
return ParquetMetrics.fromMetadata(footer);
}

@Override
Expand All @@ -60,6 +61,7 @@ public long length() {
public void close() throws IOException {
if (writer != null) {
writer.close();
this.footer = writer.getFooter();
this.writer = null;
}
}
Expand Down