Skip to content

Conversation

@jackylee-ch
Copy link
Contributor

@jackylee-ch jackylee-ch commented Oct 13, 2025

While reading the code, I noticed unused imports in ExtendedDataSourceV2Strategy that were missed by the regular syntax checker. I tried with Scalafix, and it successfully detected several redundant imports.

@github-actions github-actions bot added the spark label Oct 13, 2025
@jackylee-ch
Copy link
Contributor Author

I’m still getting familler with ScalaFix — if we are open to adopting it, I’d be happy to help integrate it more widely and contribute additional Scala linting rules.

@jackylee-ch jackylee-ch force-pushed the remove_unused_import_for_spark_extension_4.0 branch from ae62be4 to c1423d7 Compare October 13, 2025 09:48
@jackylee-ch jackylee-ch changed the title Spark: Removed the unused imports in Spark v4.0 modules Spark: Removed the unused imports in Spark modules Oct 13, 2025
@jackylee-ch jackylee-ch changed the title Spark: Removed the unused imports in Spark modules Spark: Removed the unused imports in Scala Files Oct 13, 2025
Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @jackylee-ch !

Having a scala style would be really helpful, There has been discussion about this in past

@huaxingao huaxingao merged commit 88349d2 into apache:main Oct 13, 2025
27 checks passed
@huaxingao
Copy link
Contributor

Thanks @jackylee-ch for the PR! Thanks @singhpk234 for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants