Hive: Fix newly added encryption keys getting lost in transactions #14427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committing transactions triggers a refresh() call on underlying table operations. HiveTableOperations recreates its encryption manager on such invocations, so any new encryption key stored in the EM's transient state will be lost. Effectively, appends within transactions will result in encrypted manifest lists with their encryption key being thrown away.
Contributor
|
cc @ggershinsky |
ggershinsky
approved these changes
Oct 28, 2025
Contributor
ggershinsky
left a comment
ggershinsky
left a comment
There was a problem hiding this comment.
Thanks @szlta , LGTM.
szlta
changed the title
huaxingao
approved these changes
Oct 28, 2025
Contributor
|
Thanks @szlta for the PR! Thanks @ggershinsky for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committing transactions triggers a
refresh()call on underlying table operations before the actual commit happens.HiveTableOperationsrecreates itsEncryptionManageron such invocations, so any new encryption key stored in the EM's transient state will be lost.Effectively, appends within transactions will result in encrypted manifest lists with their encryption key being thrown away.