Core: Fix failure when finding a column during time travel #14438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
commented
Oct 29, 2025
| .newScan() | ||
| .useSnapshot(firstSnapshotId) | ||
| .filter(Expressions.equal("part", "one")) | ||
| .planFiles()); |
Contributor
Author
There was a problem hiding this comment.
The planFiles() fails with the below exception without this PR's change:
Cannot find source column for partition field: 1001: hour: identity(4)
org.apache.iceberg.exceptions.ValidationException: Cannot find source column for partition field: 1001: hour: identity(4)
at org.apache.iceberg.exceptions.ValidationException.check(ValidationException.java:49)
at org.apache.iceberg.PartitionSpec.checkCompatibility(PartitionSpec.java:656)
at org.apache.iceberg.PartitionSpec$Builder.build(PartitionSpec.java:628)
at org.apache.iceberg.PartitionSpec$Builder.build(PartitionSpec.java:623)
at org.apache.iceberg.UnboundPartitionSpec.bind(UnboundPartitionSpec.java:46)
at org.apache.iceberg.SnapshotScan.specs(SnapshotScan.java:98)
at org.apache.iceberg.DataTableScan.doPlanFiles(DataTableScan.java:77)
at org.apache.iceberg.SnapshotScan.planFiles(SnapshotScan.java:161)
singhpk234
approved these changes
Oct 29, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, thanks @ebyhr !
binding with ignore missing fields make senes to me, It would be really nice to add column drop case too.
pvary
approved these changes
Oct 29, 2025
Contributor
|
Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13301 broke an existing test about time-travel with new partition columns in Trino Iceberg connector.
We should fix the regression before releasing 1.11.0.