You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds the upcoming flink-runtime module, and associated top level directory, to be tagged under flink like the current spark-runtime and associated top level spark directories / different spark modules are all tagged as spark.
The pending PR which adds the flink-runtime module is here: #1423
cc @openinx as you are the one who is adding the flink-runtime module in the PR mentioned, but it's not currently labeled flink.
cc @rdblue (sorry that you probably get CC'd on like 75% of PRs), as you were the one who noticed the original bug on the above mentioned flink-runtime PR as it didn't properly tag the updates to build.gradle with the build label. I figured I'd proactively add flink-runtime to flink while I was making these changes.
I'm merging this now, since it doesn't depend on #1423. Thanks for fixing this, @kbendick!
I'm not 100% sure if the labels will be added to that PR once another push is made or if the autolabeler only runs on PR opening. Either way, it will add the flink label to anything that goes in the upcoming flink-runtime directory going forward. As always, happy to be able to contribute any way that I can @rdblue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the upcoming
flink-runtimemodule, and associated top level directory, to be tagged underflinklike the currentspark-runtimeand associated top level spark directories / different spark modules are all tagged asspark.The pending PR which adds the
flink-runtimemodule is here: #1423This closes this issue: #1448