Core, API, Spark: Add option to restore schema during rollback #14600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
reviewed
Nov 17, 2025
Comment on lines
+670
to
+672
| default UpdateSchema rollbackTo(int schemaId) { | ||
| throw new UnsupportedOperationException(); | ||
| } |
Contributor
There was a problem hiding this comment.
per this particular comment : #5591 (comment)
Seems like its intention not to rollback to prev schema, any reason why it ok to do it now ?
It has a possible mitigation for undelete with required column by read defaults mentioned, any reason why this over that ?
Contributor
Author
There was a problem hiding this comment.
As far as I know, the situation hasn't changed since #5591.
This is essentially an initial exploration of whether we can offer a schema rollback option.
That's why the option is disabled by default in the Spark procedures in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #14488 and #5591
Add
rollbackTo(int schemaId)method toUpdateSchema, and use it from Sparkrollback_to_snapshotandrollback_to_timestampprocedures when a new parameterrollback_schemais enabled.