Skip to content

Test: Avoid deprecated AvroParquetWriter.builder(Path file) #14620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huaxingao merged 2 commits into from
Nov 20, 2025
Merged

Test: Avoid deprecated AvroParquetWriter.builder(Path file) #14620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3a443c
Test: Avoid deprecated AvroParquetWriter.builder(Path file)
ebyhr Nov 19, 2025
4b00080
fixup! Test: Avoid deprecated AvroParquetWriter.builder(Path file)
ebyhr Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import java.util.List;
import org.apache.avro.generic.GenericData;
import org.apache.avro.generic.GenericRecordBuilder;
import org.apache.hadoop.fs.Path;
import org.apache.iceberg.Files;
import org.apache.iceberg.Schema;
import org.apache.iceberg.avro.AvroSchemaUtil;
Expand All @@ -45,6 +44,7 @@
import org.apache.iceberg.types.Types;
import org.apache.parquet.avro.AvroParquetWriter;
import org.apache.parquet.hadoop.ParquetWriter;
import org.apache.parquet.io.LocalOutputFile;
import org.junit.jupiter.api.Test;

public class TestGenericData extends DataTestBase {
Expand Down Expand Up @@ -142,7 +142,8 @@ public void testTwoLevelList() throws IOException {
File testFile = temp.resolve("test-file" + System.nanoTime()).toFile();

ParquetWriter<org.apache.avro.generic.GenericRecord> writer =
AvroParquetWriter.<org.apache.avro.generic.GenericRecord>builder(new Path(testFile.toURI()))
AvroParquetWriter.<org.apache.avro.generic.GenericRecord>builder(
new LocalOutputFile(testFile.toPath()))
.withDataModel(GenericData.get())
.withSchema(avroSchema)
.config("parquet.avro.add-list-element-records", "true")
Expand Down
5 changes: 3 additions & 2 deletions .../src/test/java/org/apache/iceberg/data/parquet/TestParquetEncryptionWithWriteSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import java.util.List;
import org.apache.avro.generic.GenericData;
import org.apache.avro.generic.GenericRecordBuilder;
import org.apache.hadoop.fs.Path;
import org.apache.iceberg.Files;
import org.apache.iceberg.Schema;
import org.apache.iceberg.avro.AvroSchemaUtil;
Expand All @@ -50,6 +49,7 @@
import org.apache.parquet.crypto.FileEncryptionProperties;
import org.apache.parquet.crypto.ParquetCryptoRuntimeException;
import org.apache.parquet.hadoop.ParquetWriter;
import org.apache.parquet.io.LocalOutputFile;
import org.junit.jupiter.api.Test;

public class TestParquetEncryptionWithWriteSupport extends DataTestBase {
Expand Down Expand Up @@ -160,7 +160,8 @@ public void testTwoLevelList() throws IOException {
.build();

ParquetWriter<org.apache.avro.generic.GenericRecord> writer =
AvroParquetWriter.<org.apache.avro.generic.GenericRecord>builder(new Path(testFile.toURI()))
AvroParquetWriter.<org.apache.avro.generic.GenericRecord>builder(
new LocalOutputFile(testFile.toPath()))
.withDataModel(GenericData.get())
.withSchema(avroSchema)
.withEncryption(fileEncryptionProperties)
Expand Down
4 changes: 2 additions & 2 deletions flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import org.apache.avro.generic.GenericRecordBuilder;
import org.apache.flink.table.data.RowData;
import org.apache.flink.table.types.logical.LogicalType;
import org.apache.hadoop.fs.Path;
import org.apache.iceberg.Files;
import org.apache.iceberg.Schema;
import org.apache.iceberg.avro.AvroSchemaUtil;
Expand All @@ -52,6 +51,7 @@
import org.apache.iceberg.types.Types;
import org.apache.parquet.avro.AvroParquetWriter;
import org.apache.parquet.hadoop.ParquetWriter;
import org.apache.parquet.io.LocalOutputFile;
import org.apache.parquet.schema.LogicalTypeAnnotation;
import org.apache.parquet.schema.MessageType;
import org.apache.parquet.schema.PrimitiveType;
Expand Down Expand Up @@ -188,7 +188,7 @@ public void testTwoLevelList() throws IOException {
assertThat(testFile.delete()).isTrue();

ParquetWriter<GenericRecord> writer =
AvroParquetWriter.<GenericRecord>builder(new Path(testFile.toURI()))
AvroParquetWriter.<GenericRecord>builder(new LocalOutputFile(testFile.toPath()))
.withDataModel(GenericData.get())
.withSchema(avroSchema)
.config("parquet.avro.add-list-element-records", "true")
Expand Down
3 changes: 2 additions & 1 deletion parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
import org.apache.parquet.hadoop.ParquetWriter;
import org.apache.parquet.hadoop.metadata.BlockMetaData;
import org.apache.parquet.hadoop.metadata.ColumnChunkMetaData;
import org.apache.parquet.io.LocalOutputFile;
import org.apache.parquet.schema.MessageType;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
Expand Down Expand Up @@ -193,7 +194,7 @@ public void testTwoLevelList() throws IOException {
File testFile = new File(temp.toFile(), "test" + System.nanoTime() + ".parquet");

ParquetWriter<GenericRecord> writer =
AvroParquetWriter.<GenericRecord>builder(new org.apache.hadoop.fs.Path(testFile.toURI()))
AvroParquetWriter.<GenericRecord>builder(new LocalOutputFile(testFile.toPath()))
.withDataModel(GenericData.get())
.withSchema(avroSchema)
.config("parquet.avro.add-list-element-records", "true")
Expand Down