Core: Support incremental Scan in RESTCatalogAdapter for RemoteScanPlanning #14661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
requested review from
amogh-jahagirdar and
nastra
and removed request for
amogh-jahagirdar
nastra
reviewed
Nov 24, 2025
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java
Outdated
Show resolved
Hide resolved
nastra
approved these changes
Nov 24, 2025
huaxingao
reviewed
Nov 24, 2025
huaxingao
approved these changes
Nov 24, 2025
Contributor
Author
|
Thanks for review @nastra @huaxingao ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
Presently the RESTCatalogAdapter supports only point in time scans and not incremental scan, spec allows incremental scan
iceberg/open-api/rest-catalog-open-api.yaml
Line 627 in 4522218
Testing
There is a disabled test for this in the client side PR for this
https://github.com/apache/iceberg/pull/13400/files#diff-37f64b622d5c3e0e890d94773e84ef49ceb3c1e9b0c03da313db9266b0e75afbR3441