GCP: Add gcp.auth.credentials-json property #14713
Conversation
RyanSkraba
left a comment
RyanSkraba
left a comment
There was a problem hiding this comment.
I think this is a great idea -- it would help us in our deployment as well if we didn't need to drop a file or environment variable into our Iceberg Kafka Connectors.
What do you think about applying this same logic into reading/writing from GCS in the GCS PrefixedStorage?
docs/docs/configuration.md
Outdated
| | Property | Default | Description | | ||
| |----------------------------|--------------------------------------------------|--------------------------------------------------| | ||
| | `gcp.auth.credentials-path`| Application Default Credentials (ADC) | Path to a service account JSON key file. | | ||
| | `gcp.auth.credentials-key` | Application Default Credentials (ADC) | JSON string of a service account credential. | |
There was a problem hiding this comment.
| | `gcp.auth.credentials-key` | Application Default Credentials (ADC) | JSON string of a service account credential. | | |
| | `gcp.auth.credentials-json` | Application Default Credentials (ADC) | JSON string of a service account credential. | |
Just a suggestion: There's two other GCS connectors by Confluent and Aiven that use gcs.credentials.path and gcs.credentials.json which are slightly more descriptive at first glance. key by itself can be a bit confusing for the intention.
It's too bad we didn't all standardize on the same names, but that ship has sailed 😄
There was a problem hiding this comment.
Thanks for your feedback! I renamed it to gcp.auth.credentials-json.
ebyhr
changed the title
ebyhr
force-pushed
the
ebi/gcs
branch
2 times, most recently
from
6e380b9 to
6330456
Compare
|
@danielcweeks @nastra @talatuyarer Could you please review this PR when you have time? |
2 participants
Trino supports both
gcs.json-key-file-path(credentials file) andgcs.json-key(credentials key) in the GCS file system module. https://trino.io/docs/current/object-storage/file-system-gcs.html#authenticationThe new property simplifies deployment because it removes the need for a separate file.