-
Notifications
You must be signed in to change notification settings - Fork 3k
REST: Reuse table metadata as part of LoadTable in serializable table #14944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
singhpk234
wants to merge
4
commits into
apache:main
Choose a base branch
from
singhpk234:rest-catalog-serializable-table-optimization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
REST: Reuse table metadata as part of LoadTable in serializable table #14944
singhpk234
wants to merge
4
commits into
apache:main
from
singhpk234:rest-catalog-serializable-table-optimization
+200
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8baa35a to
87130b3
Compare
c712137 to
ac3e173
Compare
ac3e173 to
79b5352
Compare
79b5352 to
676dd48
Compare
singhpk234
commented
Jan 5, 2026
| } | ||
|
|
||
| public static class MetadataLogEntry { | ||
| public static class MetadataLogEntry implements Serializable { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should fix this irrespective, IMHO
nastra
reviewed
Jan 7, 2026
nastra
reviewed
Jan 7, 2026
nastra
reviewed
Jan 7, 2026
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 7, 2026
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 7, 2026
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 7, 2026
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 7, 2026
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 7, 2026
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 7, 2026
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
This change attempts to avoid object store call to recreate the TableMetadata from the object store in case we are making a serialized table copy of the table, this could be seen as an optimization where rather than going to the obj store we keep the serialized copy of the table metadata and then just store it and send it via wire for example (spark driver sending to executor) or can also be looked as a feature where if the catalog has redacted some sensitive info, all the serializable table respects it and reads that rather than going to the object store (which it may not have access to) for example:
Presently its gauraded only for Remotely planned tables
I understand that spec wording the following:
Per REST spec the metadata location is nullable in certain cases
iceberg/open-api/rest-catalog-open-api.yaml
Lines 3396 to 3399 in 4632f31
Addditionally we can send metadata location as null to force this scenario :
The spec says the following but that is SHOULD and not MUST :
iceberg/open-api/rest-catalog-open-api.yaml
Line 3365 in 4632f31
just wanted to float this to folks on what they think of this feature.