Kafka Connect: fix table UUID check#15011
Merged
bryanck merged 2 commits intoapache:mainfrom Jan 9, 2026
Merged
Conversation
amogh-jahagirdar
approved these changes
Jan 9, 2026
Contributor
|
Looks like there's some related failing tests, though it may just be a gap in expectations/assumptions based on the new UUID check. But thanks for fixing this @bryanck , and thanks for catching this @singhpk234 ! |
singhpk234
approved these changes
Jan 9, 2026
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM thanks @bryanck !
Contributor
Author
|
Thanks for the review @amogh-jahagirdar and @singhpk234 ! |
Contributor
|
Late +1, Thanks @bryanck! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of fixes to the table UUID check that was added to the Kafka Connect coordinator. First, it skips the commit if the UUIDs don't match, currently it just logs a warning but continues on. Second, it only compares the UUID if the message had it set. This is to handle the upgrade case, where existing messages in the control topic do not have the UUID set because they were created before this change was added.