Conversation
|
@pvary, what's the status here? I took a quick look at the changes and I see some timestamp changes mixed in? |
This patch is changing the big test class used by most of the Hive/Tez/Mr tests (HiveIcebergStorageHandlerBaseTest), so this messes up with most of the Hive patches. I based this patch on the current version of |
If the the test is independed of the FileFormat/Execution engine then only run ti on every Catalog
|
Created #1840 (Hive: Refactor HiveIcebergStorageHandler tests to use catalogs as parameters) as a first part of this change |
|
I ran into this issue over the break and found that on my local machine, the storage handler tests were taking 11 minutes to run and running for both Hive 2 and Hive 3. It would be great to get this refactor done and not run so many expensive cases! |
Running the iceberg-mr/iceberg-hive3 tests are beginning to take serious amount of time.
This is partially because every tests are run 24 times (2 Engines X 3 FileFormats X 4 Catalogs). We can separate out some of the tests which does not depend the FileFormat/Catalog and this way we can save time.
Also the Catalog tests are still using inheritance which we can replace with parametrized tests for cleaner code.
The current patch is above #1612 since I do not want to rebase that patch again 😄