API: move NaN validation from Expressions to Literals #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
Dec 8, 2020
| @SuppressWarnings("unchecked") | ||
| static <T> Literal<T> from(T value) { | ||
| Preconditions.checkNotNull(value, "Cannot create expression literal from null"); | ||
| Preconditions.checkArgument(!NaNUtil.isNaN(value), "Cannot expression literal from NaN"); |
Contributor
There was a problem hiding this comment.
Looks like the verb is missing. It should be "Cannot create expression literal from NaN".
Contributor
Author
There was a problem hiding this comment.
Yes, sorry should have double checked... I include the fix of this in #1857 since I think they are kind of related, but please let me know if you want a separate PR for that!
Contributor
|
Thanks @yyanyy! I think this just needs to fix the exception message and then it's ready to go in. |
Contributor
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up item from #1747 to clean up
Expressionsa bit. No behavior change.