Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet: Enable vectorized reads by default #4196

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Parquet: Enable vectorized reads by default #4196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9326ae
Parquet: Enabled vectorized reads by default
aokolnychyi Feb 22, 2022
f9d2c1e
Read INT96 timestamps without vectorization
aokolnychyi Feb 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/iceberg/TableProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ private TableProperties() {
public static final long SPLIT_OPEN_FILE_COST_DEFAULT = 4 * 1024 * 1024; // 4MB

public static final String PARQUET_VECTORIZATION_ENABLED = "read.parquet.vectorization.enabled";
public static final boolean PARQUET_VECTORIZATION_ENABLED_DEFAULT = false;
public static final boolean PARQUET_VECTORIZATION_ENABLED_DEFAULT = true;

public static final String PARQUET_BATCH_SIZE = "read.parquet.vectorization.batch-size";
public static final int PARQUET_BATCH_SIZE_DEFAULT = 5000;
Expand Down
3 changes: 2 additions & 1 deletion .../src/test/java/org/apache/iceberg/spark/source/TestSparkTableUtilWithInMemoryCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,9 +451,10 @@ public void testImportTableWithInt96Timestamp() throws IOException {
);
Table table = TABLES.create(schema, PartitionSpec.unpartitioned(), tableLocation);

// assign a custom metrics config
// assign a custom metrics config and disable vectorized reads
table.updateProperties()
.set(TableProperties.DEFAULT_WRITE_METRICS_MODE, "full")
.set(TableProperties.PARQUET_VECTORIZATION_ENABLED, "false")
.commit();

File stagingDir = temp.newFolder("staging-dir");
Expand Down