Skip to content

Flink: fix missing copy in ScanContext #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 1 commit into from
Mar 16, 2022
Merged

Flink: fix missing copy in ScanContext #4341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,9 @@ ScanContext copyWithAppendsBetween(long newStartSnapshotId, long newEndSnapshotI
.project(schema)
.filters(filters)
.limit(limit)
.exposeLocality(exposeLocality)
.includeColumnStats(includeColumnStats)
.exposeLocality(exposeLocality)
Copy link
Contributor

@rdblue rdblue Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did exposeLocality move? To be consistent?

Copy link
Contributor

@stevenzwu stevenzwu Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. this is to be consistent with the ordering of how variables are defined

.planParallelism(planParallelism)
.build();
}

Expand All @@ -223,6 +224,7 @@ ScanContext copyWithSnapshotId(long newSnapshotId) {
.limit(limit)
.includeColumnStats(includeColumnStats)
.exposeLocality(exposeLocality)
.planParallelism(planParallelism)
.build();
}

Expand Down