Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core : Strip trailing slash from tableLocation in LocationProvider #4585

Merged
merged 6 commits into from
Apr 20, 2022

Conversation

singhpk234
Copy link
Contributor

@singhpk234 singhpk234 commented Apr 19, 2022

Closes #4582

This change attempts to fix :

  1. In locationsFor we don't sanitize the location (i.e strip the trailing slash), this attempts to do this stripping
  2. The warehouse location for hiveCatalog is also missing this handling rest all catalogs such as Hadoop / Glue have these handling
  3. Had to refactor a bit, slash stripping logic was duplicated in all catalogs.
    Note : nessie Catalog also doesn't have this handling, will do the same in next iteration of this pr if experts from nessie suggests this is required (appologies I am new to nessie)
  4. Fixes a minor typo.

cc @szehon-ho , @RussellSpitzer , @jackye1995 , @flyrain

@github-actions github-actions bot added the hive label Apr 19, 2022
@rdblue
Copy link
Contributor

rdblue commented Apr 19, 2022

Thanks, @singhpk234! Looks mostly good, but I think we should use just one stripTrailingSlash method.

@rdblue rdblue merged commit 360b566 into apache:master Apr 20, 2022
@rdblue
Copy link
Contributor

rdblue commented Apr 20, 2022

Thanks, @singhpk234!

sunchao pushed a commit to sunchao/iceberg that referenced this pull request May 9, 2023
Co-authored-by: Prashant Singh <psinghvk@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extraneous trailing slash in table location
2 participants