Skip to content

Conversation

@aokolnychyi
Copy link
Contributor

This PR renames recently added and unreleased snapshot summary properties for equality and position delete files to match other recent public constants/methods.

Specifically, all other snapshot properties use full words for equality and position.

// SnapshotSummary
public static final String ADDED_POS_DELETES_PROP = "added-position-deletes";
public static final String REMOVED_POS_DELETES_PROP = "removed-position-deletes";
public static final String TOTAL_POS_DELETES_PROP = "total-position-deletes";
public static final String ADDED_EQ_DELETES_PROP = "added-equality-deletes";

// ConvertEqualityDeleteFiles
int convertedEqualityDeleteFilesCount();
int addedPositionDeleteFilesCount();

// FileWriterFactory
EqualityDeleteWriter<T> newEqualityDeleteWriter(...);
PositionDeleteWriter<T> newPositionDeleteWriter(...);

etc

Since the new snapshot summary properties haven't been released yet and were added recently, I'd consider renaming them for consistency.

@github-actions github-actions bot added the core label May 13, 2022
@aokolnychyi
Copy link
Contributor Author

@chenjunjiedada @rdblue, what do you think?

@rdblue
Copy link
Contributor

rdblue commented May 13, 2022

Looks good to me.

@chenjunjiedada
Copy link
Collaborator

+1 to me.

@aokolnychyi aokolnychyi merged commit f853662 into apache:master May 14, 2022
@aokolnychyi
Copy link
Contributor Author

Thanks, @rdblue @szehon-ho @chenjunjiedada!

kazuyukitanimura pushed a commit to kazuyukitanimura/spark that referenced this pull request Aug 10, 2022
Iceberg 0.13.0.3 - ADT 1.1.7

2022-05-20

PRs Merged

* Internal: Parquet bloom filter support (apache#594 (https://github.pie.apple.com/IPR/apache-incubator-iceberg/pull/594))
* Internal: AWS Kms Client (apache#630 (https://github.pie.apple.com/IPR/apache-incubator-iceberg/pull/630))
* Internal: Core: Add client-side check of encryption properties (apache#626 (https://github.pie.apple.com/IPR/apache-incubator-iceberg/pull/626))
* Core: Align snapshot summary property names for delete files (apache#4766 (apache/iceberg#4766))
* Core: Add eq and pos delete file counts to snapshot summary (apache#4677 (apache/iceberg#4677))
* Spark 3.2: Clean static vars in SparkTableUtil (apache#4765 (apache/iceberg#4765))
* Spark 3.2: Avoid reflection to load metadata tables in SparkTableUtil (apache#4758 (apache/iceberg#4758))
* Core: Fix query failure when using projection on top of partitions metadata table (apache#4720) (apache#619 (https://github.pie.apple.com/IPR/apache-incubator-iceberg/pull/619))

Key Notes

Bloom filter support and Client Side Encryption Features can be used in this release. Both features are only enabled with explicit flags and will not effect existing tables or jobs.
sunchao pushed a commit to sunchao/iceberg that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants