Skip to content

Infra - Fix API compatibility Github Action #4989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 5 commits into from
Jun 8, 2022
Merged

Infra - Fix API compatibility Github Action #4989

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b076d0
Infra - Fix API compatibility Github Action
kbendick Jun 7, 2022
d5076de
Remove --no-build-cache and --no-daemon and add a note re: fetch dept…
kbendick Jun 7, 2022
a1116da
Add attribution note for the github action issue that resolved this
kbendick Jun 7, 2022
897b8db
Use checkout v3 and remove difference between push and pull
kbendick Jun 8, 2022
809ee7d
Run on same ubuntu version as other actions
kbendick Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .github/workflows/api-binary-compatibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,22 @@ concurrency:

jobs:
revapi:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
Copy link
Contributor Author

@kbendick kbendick Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to match our other actions.

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
# fetch-depth of zero ensures that the tags are pulled in and we're not in a detached HEAD state
# revapi depends on the tags, specifically the tag from git describe, to find the relevant override
# in the .palantir/revapi.yml file
#
# See https://github.com/actions/checkout/issues/124
fetch-depth: 0
- uses: actions/setup-java@v1
with:
java-version: 11
- uses: actions/cache@v2
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
- run: ./gradlew :iceberg-api:revapi
Copy link
Contributor Author

@kbendick kbendick Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can potentially add back in the cache step, but for now I'd like to get this working in master before fiddling with the individual arguments any further.

- run: |
echo "Using the old version tag, as per git describe, of $(git describe)";
- run: ./gradlew :iceberg-api:revapi --rerun-tasks
- uses: actions/upload-artifact@v2
if: failure()
with:
Expand Down