Python: Replace vars with cached_property decorator#5068
Merged
danielcweeks merged 1 commit intoapache:masterfrom Jun 21, 2022
Merged
Python: Replace vars with cached_property decorator#5068danielcweeks merged 1 commit intoapache:masterfrom
danielcweeks merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@samredai would you have time to look at this? Since you're the original author 👍🏻 |
danielcweeks
approved these changes
Jun 21, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing the caching ourselves, functools has a nice decorator that can do that for us. I also removed the type ignore to avoid having an accidental None.