Skip to content

Inline PuffinWriter.writeFully #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 1 commit into from
Jun 20, 2022
Merged

Inline PuffinWriter.writeFully #5088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions core/src/main/java/org/apache/iceberg/puffin/PuffinWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public void add(Blob blob) {
PuffinCompressionCodec codec = MoreObjects.firstNonNull(blob.requestedCompression(), defaultBlobCompression);
ByteBuffer rawData = PuffinFormat.compress(codec, blob.blobData());
int length = rawData.remaining();
writeFully(rawData);
IOUtil.writeFully(outputStream, rawData);
writtenBlobsMetadata.add(new BlobMetadata(blob.type(), blob.inputFields(), fileOffset, length,
codec.codecName(), blob.properties()));
} catch (IOException e) {
Expand Down Expand Up @@ -132,7 +132,7 @@ private void writeFooter() throws IOException {
ByteBuffer footerPayload = PuffinFormat.compress(footerCompression, footerJson);
outputStream.write(MAGIC);
int footerPayloadLength = footerPayload.remaining();
writeFully(footerPayload);
IOUtil.writeFully(outputStream, footerPayload);
PuffinFormat.writeIntegerLittleEndian(outputStream, footerPayloadLength);
writeFlags();
outputStream.write(MAGIC);
Expand All @@ -150,10 +150,6 @@ private void writeFlags() throws IOException {
}
}

private void writeFully(ByteBuffer buffer) throws IOException {
IOUtil.writeFully(outputStream, buffer);
}

public long footerSize() {
return footerSize.orElseThrow(() -> new IllegalStateException("Footer not written yet"));
}
Expand Down