Spark 3.3: Re-Enable TwoLevel Parquet List UT #5179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
changed the title
singhpk234
force-pushed
the
fix/re-enable-two-level-list-ut
branch
from
27ed9cb to
8fdb98f
Compare
rdblue
approved these changes
Jul 3, 2022
Contributor
|
Thanks, @singhpk234! Looks great. |
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
Co-authored-by: Prashant Singh <psinghvk@amazon.com>
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
Co-authored-by: Prashant Singh <psinghvk@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Address #5094 (comment)
Spark was writing 3 level list rather than 2 level list which was expected in the UT.
On debugging this more found that, since the schema was passed via
spark.read().schema(sparkSchema).jsonand as of spark 3.3 spark will not respect the nullability in the schema passed via above by default (ref. this).Now since the nullability is not respected (will be considered nullable) by spark by default the Parquet writer despite
writeLegacyParquetFormatbeing true, will write in Three level list. CodePointerThis pr adds the conf to respect the nullability provided presently and hence preserves the existing behaviour.
P.S : A good long term fix would be to get rid of this form of specifying schema from our test / test utils, can pick this in a follow-up.
Testing Done
Re-enabled the UT, which was ignored in version upgrade.
cc @rdblue