Spark-2.4: Handle no-op for rewrite manifests action #6733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
commented
Feb 3, 2023
| @@ -478,6 +492,33 @@ public void testRewriteManifestsWithPredicate() throws IOException { | |||
| Assert.assertEquals("Rows must match", expectedRecords, actualRecords); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testRewriteManifestsNoOp() throws IOException { | |||
There was a problem hiding this comment.
This is an additional test case for the scenario which was covered by spark procedure in 3.1 and above spark versions.
Rest of the changes in the PR is same as #6695
aokolnychyi
approved these changes
Feb 3, 2023
danielcweeks
pushed a commit
to danielcweeks/iceberg
that referenced
this pull request
Feb 12, 2023
krvikash
pushed a commit
to krvikash/iceberg
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #6695
Note that spark-2.4 doesn't have call procedures. Hence, only two file changes.
Also, Added a No-op testcase newly for the spark action itself as there is no procedure to cover that scenario.