Spark-3.2: Bug Fix for Reading Metadata tables with Snapshot ID #6994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@szehon-ho may I ask you for a review on this one as well? This one is thankfully almost identical to its 3.3 equivalent - I'm hoping that makes it easier for you to review! |
szehon-ho
reviewed
Mar 3, 2023
| List<Record> expectedFiles = | ||
| expectedEntries(table, FileContent.DATA, entriesTableSchema, expectedDataManifests, null); | ||
|
|
||
| Assert.assertEquals("actualFiles size should be 1", 2, actualFiles.size()); |
Member
There was a problem hiding this comment.
Just noticed this message is wrong, can we fix it? (In all the versions)
Contributor
Author
There was a problem hiding this comment.
Thank you for the catch!
szehon-ho
approved these changes
Mar 3, 2023
Member
|
Merged, thanks @syun64 |
krvikash
pushed a commit
to krvikash/iceberg
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6978
Spark-3.2 backport of #6980