-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec: deprecate distinct_counts in data_file #8395
Spec: deprecate distinct_counts in data_file #8395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for finding this out and fixing it.
PR title can be
"Spec: deprecate distint_counts in data_file"
Thanks for the LGTM, I cannot merge since I don't have write access, would you merge it please? |
I think we can just remove it from the spec, no need to deprecate it, because deprecating would mean that there's still code that reads this field |
Long back while removing some fields from code, we just deprecated in the spec. So, I suggested a similar approach for this instead of removing. |
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Deprecating 111 distinct_counts, which was removed a long time ago