Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API, Core: Add UUID API to Table #8800

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

amogh-jahagirdar
Copy link
Contributor

This change exposes the underlying table metadata UUID via the Table API for easier access (currently one has to go through multiple hops + casting to get these details, but since a table should always have a defined UUID it will make it easier for clients to just access it via an API)

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM, but I think there should be a check in CatalogTests#testCompleteCreateTable() that makes sure the UUID on the table is set

@amogh-jahagirdar
Copy link
Contributor Author

this LGTM, but I think there should be a check in CatalogTests#testCompleteCreateTable() that makes sure the UUID on the table is set

Sure thing, I can add a test for this

@nastra nastra merged commit a7828db into apache:main Oct 30, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants