Remove redundant error propagation check. #9143
Conversation
| @@ -58,7 +58,6 @@ public C newInstanceChecked(Object... args) throws Exception { | |||
| throw e; | |||
| } catch (InvocationTargetException e) { | |||
| Throwables.propagateIfInstanceOf(e.getCause(), Exception.class); | |||
| Throwables.propagateIfInstanceOf(e.getCause(), RuntimeException.class); | |||
There was a problem hiding this comment.
I think this line is never reached as the previous line always catches even RuntimeExceptions, so it is safe to remove this.
common/src/main/java/org/apache/iceberg/common/DynConstructors.java
Outdated
Show resolved
Hide resolved
| @@ -62,7 +62,6 @@ public <R> R invokeChecked(Object target, Object... args) throws Exception { | |||
|
|
|||
| } catch (InvocationTargetException e) { | |||
| Throwables.propagateIfInstanceOf(e.getCause(), Exception.class); | |||
| Throwables.propagateIfInstanceOf(e.getCause(), RuntimeException.class); | |||
There was a problem hiding this comment.
I think it is ok to remove this - see comment above
nk1506
force-pushed
the
minor_rte_fix
branch
from
93d6894 to
972c185
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Throwables.propagate always translate to
RuntimeExceptionAdding another check as
Throwables.propagateIfInstanceOf(e.getCause(), RuntimeException.class);is redundant.