Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flink: fix flaky test that might fail due to classloader check #9216

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

stevenzwu
Copy link
Contributor

No description provided.

@stevenzwu stevenzwu requested a review from pvary December 5, 2023 00:32
@github-actions github-actions bot added the flink label Dec 5, 2023
@stevenzwu
Copy link
Contributor Author

see an example of failed test here: https://github.com/apache/iceberg/actions/runs/7091452262/job/19300609355?pr=9212

    exception caught while trying to get the future result: java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Trying to access closed classloader. Please check if you store classloaders directly or indirectly in static fields. If the stacktrace suggests that the leak occurs in a third party library and cannot be fixed immediately, you can disable this check with the configuration 'classloader.check-leaked-classloader'.
    	at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
    	at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1928)
    	at org.assertj.core.internal.Futures.assertSucceededWithin(Futures.java:109)
    	at org.assertj.core.api.AbstractCompletableFutureAssert.internalSucceedsWithin(AbstractCompletableFutureAssert.java:400)
    	at org.assertj.core.api.AbstractCompletableFutureAssert.succeedsWithin(AbstractCompletableFutureAssert.java:396)
    	at org.apache.iceberg.flink.source.TestIcebergSourceWithWatermarkExtractor.waitForRecords(TestIcebergSourceWithWatermarkExtractor.java:416)
    	at org.apache.iceberg.flink.source.TestIcebergSourceWithWatermarkExtractor.testThrottling(TestIcebergSourceWithWatermarkExtractor.java:307)

@pvary pvary merged commit cbd33a6 into apache:main Dec 5, 2023
13 checks passed
@pvary
Copy link
Contributor

pvary commented Dec 5, 2023

Thanks for catching and fixing this @stevenzwu !

@ajantha-bhat
Copy link
Member

I think this is not fully fixed.

With the latest code, it has failed again
https://github.com/apache/iceberg/actions/runs/7208855885/job/19638664888?pr=9296

cc: @nastra, @stevenzwu, @pvary

@ajantha-bhat
Copy link
Member

@stevenzwu: Looks like the code is already there in 1.16, but still it is failed. Please take a look.

@stevenzwu
Copy link
Contributor Author

stevenzwu commented Dec 15, 2023

@pvary can you follow up? if this can't be fixed quickly, let's ignore this test for now

@pvary
Copy link
Contributor

pvary commented Dec 15, 2023

I was originally not able to run the tests multiple times using IntelliJ, but found some issues, and fixed them.
Now I have a test which I was able to run 1000 times from IntelliJ without errors.
Let me prepare the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants