Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Document reading in Spark using branch and tag identifiers #9238

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

wypoon
Copy link
Contributor

@wypoon wypoon commented Dec 7, 2023

Writing to a branch or tag is supported in Spark using a table identifier with branch_<branchname> or tag_<tagname>. Reading from the branch or tag is supported using the same kind of identifier, in addition to the VERSION AS OF syntax, but this is not documented. For consistency, users may prefer to read and write using the same syntax. We should document that they can.

Note: When loading a table using identifiers with snapshot_id_ and at_timestamp_ was implemented, this was considered an implementation detail and we did not expose it publicly (i.e., document it). However, since the branch_ and tag_ identifiers are used for writes and documented, we should expose them for reads as well.

@github-actions github-actions bot added the docs label Dec 7, 2023
@wypoon
Copy link
Contributor Author

wypoon commented Dec 7, 2023

@rdblue @jackye1995 @amogh-jahagirdar what do you think?
@nastra I added a note that the identifiers may not be combined with VERSION AS OF since you disallowed it in #9219.

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wypoon

@nastra nastra merged commit af9522a into apache:main Dec 7, 2023
2 checks passed
lisirrx pushed a commit to lisirrx/iceberg that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants