Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spark 3.5] Support specifying spec_id in RewriteManifestProcedure #9242

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

puchengy
Copy link
Contributor

@puchengy puchengy commented Dec 7, 2023

As title. Current manifest rewrite in spark procedure only can be performed on manifests with current spec id. This PR allows user to specify rewrite on manifests with old spec ids.

@github-actions github-actions bot added the spark label Dec 7, 2023
@RussellSpitzer RussellSpitzer changed the title [spark 3.5] support specified spec_id in manifest rewrite [spark 3.5] Support specifying spec_id in RewriteManifestProcedure Dec 7, 2023
@RussellSpitzer
Copy link
Member

Changed the title to match the contents

Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on test, just want to make sure that the test is covering when both specs have manifests.

@RussellSpitzer RussellSpitzer merged commit 263b530 into apache:main Dec 7, 2023
35 checks passed
@RussellSpitzer
Copy link
Member

Thanks @puchengy for the pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants