-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spark 3.5] Support specifying spec_id in RewriteManifestProcedure #9242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussellSpitzer
changed the title
[spark 3.5] support specified spec_id in manifest rewrite
[spark 3.5] Support specifying spec_id in RewriteManifestProcedure
Dec 7, 2023
Changed the title to match the contents |
...ensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteManifestsProcedure.java
Show resolved
Hide resolved
RussellSpitzer
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment on test, just want to make sure that the test is covering when both specs have manifests.
Thanks @puchengy for the pr! |
RussellSpitzer
pushed a commit
that referenced
this pull request
Dec 8, 2023
This was referenced Dec 11, 2023
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Current manifest rewrite in spark procedure only can be performed on manifests with current spec id. This PR allows user to specify rewrite on manifests with old spec ids.