Core: Make sqlFor case insensitive for dialect check #9311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
approved these changes
Dec 16, 2023
|
Looks like the unrelated Flink test TestIcebergSourceWithWatermarkExtractor is still flaky? I see there's a PR out for this https://github.com/apache/iceberg/pull/9309/files I'm going to close and re-open to retrigger CI |
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the dialect check case insensitive https://github.com/apache/iceberg/pull/9247/files . Was an oversight, after I refactored the code, the case insensitive change mistakenly became case sensitive. This change also adds a test to catch this case.