IGNITE-22478 Use single argument in Compute API #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-22478 # Conflicts: # modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java # modules/api/src/main/java/org/apache/ignite/compute/task/ComputeJobRunner.java # modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientCompute.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeBaseTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeErrorsBaseTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeTestEmbedded.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeTestStandalone.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItExecutionsCleanerTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItFailoverCandidateNotFoundTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItWorkerShutdownTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/threading/ItComputeApiThreadingTest.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/AntiHijackIgniteCompute.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/IgniteComputeImpl.java # modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/PlatformTestNodeRunner.java
…-22478 # Conflicts: # modules/api/src/main/java/org/apache/ignite/compute/ComputeJob.java # modules/api/src/main/java/org/apache/ignite/compute/task/MapReduceTask.java # modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientStreamerWithReceiverBatchSendRequest.java # modules/client/src/test/java/org/apache/ignite/client/fakes/FakeCompute.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeTestEmbedded.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/threading/ItComputeApiThreadingTest.java # modules/compute/src/jobs/java/org/apache/ignite/internal/compute/FailingJob.java # modules/compute/src/jobs/java/org/apache/ignite/internal/compute/GetNodeNameJob.java # modules/compute/src/jobs/java/org/apache/ignite/internal/compute/MapReduce.java # modules/compute/src/jobs/java/org/apache/ignite/internal/compute/NonEmptyConstructorJob.java # modules/compute/src/jobs/java/org/apache/ignite/internal/compute/SleepJob.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/executor/ComputeExecutorImpl.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/task/TaskExecutionInternal.java # modules/compute/src/test/java/org/apache/ignite/internal/compute/loader/JobClassLoaderFactoryTest.java # modules/compute/src/unit1/java/org/apache/ignite/internal/compute/UnitJob.java # modules/compute/src/unit2/java/org/apache/ignite/internal/compute/UnitJob.java # modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/PlatformTestNodeRunner.java
…-22478 # Conflicts: # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItMapReduceTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/utils/InteractiveTasks.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/executor/ComputeExecutorImpl.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/task/TaskExecutionInternal.java
…-22478 # Conflicts: # modules/api/src/main/java/org/apache/ignite/compute/task/MapReduceTask.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeTestEmbedded.java # modules/compute/src/jobs/java/org/apache/ignite/internal/compute/MapReduce.java
…-22478 # Conflicts: # modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java # modules/api/src/main/java/org/apache/ignite/table/DataStreamerTarget.java # modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteColocatedRequest.java # modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteMapReduceRequest.java # modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java # modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientCompute.java # modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientJobExecution.java # modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientKeyValueBinaryView.java # modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientKeyValueView.java # modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientRecordBinaryView.java # modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientRecordView.java # modules/client/src/test/java/org/apache/ignite/client/ClientComputeTest.java # modules/client/src/test/java/org/apache/ignite/client/PartitionAwarenessTest.java # modules/client/src/test/java/org/apache/ignite/client/fakes/FakeCompute.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeBaseTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeErrorsBaseTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeTestEmbedded.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItComputeTestStandalone.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItExecutionsCleanerTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItFailoverCandidateNotFoundTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItWorkerShutdownTest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/threading/ItComputeApiThreadingTest.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/AntiHijackIgniteCompute.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/IgniteComputeImpl.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/executor/JobExecutionInternal.java # modules/compute/src/test/java/org/apache/ignite/internal/compute/ComputeComponentImplTest.java # modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/compute/ItComputeControllerTest.java # modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientComputeTest.java # modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientPartitionAwarenessTest.java # modules/table/src/main/java/org/apache/ignite/internal/table/KeyValueBinaryViewImpl.java # modules/table/src/main/java/org/apache/ignite/internal/table/KeyValueViewImpl.java # modules/table/src/main/java/org/apache/ignite/internal/table/PublicApiThreadingViewBase.java # modules/table/src/main/java/org/apache/ignite/internal/table/RecordBinaryViewImpl.java # modules/table/src/main/java/org/apache/ignite/internal/table/RecordViewImpl.java
…-22478 # Conflicts: # modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/PlatformTestNodeRunner.java
ptupitsyn
reviewed
Jun 25, 2024
modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java
Outdated
Show resolved
Hide resolved
ptupitsyn
changed the title
valepakh
reviewed
Jun 25, 2024
modules/api/src/main/java/org/apache/ignite/compute/task/MapReduceTask.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/compute/task/MapReduceTask.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/compute/ComputeJob.java
Outdated
Show resolved
Hide resolved
…ute.java Co-authored-by: Vadim Pakhnushev <8614891+valepakh@users.noreply.github.com>
…ute.java Co-authored-by: Vadim Pakhnushev <8614891+valepakh@users.noreply.github.com>
…ute.java Co-authored-by: Vadim Pakhnushev <8614891+valepakh@users.noreply.github.com>
…ute.java Co-authored-by: Vadim Pakhnushev <8614891+valepakh@users.noreply.github.com>
…ute.java Co-authored-by: Vadim Pakhnushev <8614891+valepakh@users.noreply.github.com>
…ute.java Co-authored-by: Vadim Pakhnushev <8614891+valepakh@users.noreply.github.com>
valepakh
reviewed
Jun 28, 2024
modules/api/src/main/java/org/apache/ignite/compute/task/MapReduceJob.java
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/compute/task/MapReduceJob.java
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/compute/task/MapReduceJob.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/table/DataStreamerReceiver.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/table/DataStreamerTarget.java
Outdated
Show resolved
Hide resolved
modules/api/src/main/java/org/apache/ignite/table/ReceiverDescriptor.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java
Outdated
Show resolved
Hide resolved
modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientJobExecution.java
Outdated
Show resolved
Hide resolved
modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeComponent.java
Outdated
Show resolved
Hide resolved
modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeComponentImpl.java
Outdated
Show resolved
Hide resolved
valepakh
reviewed
Jun 28, 2024
.../compute/src/main/java/org/apache/ignite/internal/compute/executor/JobExecutionInternal.java
Outdated
Show resolved
Hide resolved
...s/compute/src/test/java/org/apache/ignite/internal/compute/executor/ComputeExecutorTest.java
Outdated
Show resolved
Hide resolved
…-22478 # Conflicts: # modules/api/src/main/java/org/apache/ignite/compute/JobDescriptor.java # modules/api/src/main/java/org/apache/ignite/table/ReceiverDescriptor.java
…-22478 # Conflicts: # modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteMapReduceRequest.java # modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItMapReduceTest.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeComponentImpl.java # modules/compute/src/main/java/org/apache/ignite/internal/compute/task/TaskExecutionInternal.java # modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientComputeTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Compute API is changed:
nullby any compute job.primitives. If the one want to use custom marshaler they should declare it explicitly.
Marshalers allow us to define the default way to serialize objects:
java serialization.At the same time client can implement theirs own marshalers and use them in any
public API that supports it. This is the first implementation and it is supposed to be
improved in the future. The only thing that will not be changed -- Marshaler and
Compute interfaces (their public parts).