IGNITE-22928 Fix testZoneReplicaListener #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgusakov
suggested changes
Aug 27, 2024
| @@ -81,7 +81,11 @@ public CompletableFuture<List<TokenizedAssignments>> getAssignments( | |||
| return failedFuture(new UnsupportedOperationException("getAssignments() is not supported in FakePlacementDriver yet.")); | |||
| } | |||
|
|
|||
| private CompletableFuture<ReplicaMeta> getPrimaryReplicaMeta() { | |||
| private CompletableFuture<ReplicaMeta> getPrimaryReplicaMeta(ReplicationGroupId replicationGroupId) { | |||
| if (replicationGroupId instanceof ZonePartitionId && ((ZonePartitionId) replicationGroupId).zoneId() == 0) { | |||
There was a problem hiding this comment.
Let's name this 0 as a separate DEFAULT_ZONE_ID field
kgusakov
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: IGNITE-22928 | Fix testZoneReplicaListener
The goal
The goal is to fix the disabled test.
The reason
It fails
The solution
The main issue there is a race between switched primary replica from
TestPlacementDriverand internal logic inside of lifecycle managers. The issued zone is default, so a possible solution is to return null primary (no primary) for the default zone and thus there no the race.Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes