IGNITE-23220 Avoid concurrent Catalog writes to Metastorage on the same node #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we talk about local linearization - seems such approach is ok, but seems we still have such kind of problem with multi nodes concurrent catalog modification and the same exception will be raised. Also exception message in [1] is not clear for user and seems need to be refactored too. |
zstan
approved these changes
Sep 17, 2024
|
Thanks for your review! The issues you mention will probably be addressed in https://issues.apache.org/jira/browse/IGNITE-22813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-23220
Each DDL tries to make a write to the Metastorage. Each write is assigned a sequential number (version); if a few DDLs try to write to the Metastorage, they will all compete for the same version, and only one of them can succeed. This competition is wasteful. This commit avoids such concurrency on the same node by explicitly linearizing writes to the Metastorage from the Catalog before doing them.