Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-23879 Indicate stable switch after the second phase of resetPartitions #4916

Merged
merged 13 commits into from
Dec 24, 2024

Conversation

Cyrill
Copy link
Contributor

@Cyrill Cyrill commented Dec 17, 2024


@Test
@ZoneParams(nodes = 5, replicas = 3, partitions = 1)
public void testPlanningIsOverwritten() throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

planned

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Assignments assignmentForced1 = Assignments.forced(Set.of(Assignment.forPeer(node(1).name())), timestamp);

assertPendingAssignments(node0, partId, assignmentForced1);

// secondPhaseOfReset == true, force == false.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fromReset

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

*
* <p>The reset is executed in two stages - first we switch to a single node having the most up-to-date data,
* then we switch to other available nodes up to the configured replica factor, in the case of manual reset, and to available nodes from the
* original group, in the case of manual.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not manual

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sanpwc sanpwc merged commit 8ace698 into apache:main Dec 24, 2024
1 check passed
@Cyrill Cyrill deleted the IGNITE-23879 branch December 24, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants