IGNITE-23138 Fix TxWithKeyContentionSelfTest (Cache 12 group) #11512
+31
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earTxFinishResponse
superminkfan
force-pushed
the
IGNITE-23138
branch
from
2cee4ce
to
1f8dbfc
Compare
shishkovilja
suggested changes
Oct 28, 2024
| */ | ||
| private void startTransactions(Ignite clientIgnite, IgniteCache<Integer, Integer> cache, int contCnt, | ||
| TransactionConcurrency concurrency, TransactionIsolation isolation) { | ||
| ExecutorService executor = Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()); |
There was a problem hiding this comment.
Why should we migrate to ExecutorService from runAsync?
| TransactionConcurrency concurrency, TransactionIsolation isolation) { | ||
| ExecutorService executor = Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()); | ||
|
|
||
| for (int i = 0; i < 5; i++) { |
There was a problem hiding this comment.
Magic number. And why 5? Not 2? Not 10?
|
|
||
| assertTrue(GridTestUtils.waitForCondition(new GridAbsPredicate() { | ||
| @Override public boolean apply() { | ||
| startTransactions(cl, cache, contCnt, concurrency, isolation); |
There was a problem hiding this comment.
Why should we start transactions in the predicate?
There was a problem hiding this comment.
@superminkfan , transactions are still in the predicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.