IGNITE-23168 Event consumption time metric in CDC consumer #11612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Consumer events consumption metric
maksaska
force-pushed
the
ignite-23168
branch
from
7e57e9d
to
582b63f
Compare
shishkovilja
suggested changes
Oct 30, 2024
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java
Outdated
Show resolved
Hide resolved
| * Updates consumer event coonsumption metrics. | ||
| * @param duration - Operation durtion. | ||
| */ | ||
| private void updateWalProcessingMetrics(long duration) { |
There was a problem hiding this comment.
This method consisting of two lines is used only once, why should we add it?
There was a problem hiding this comment.
I added it for consistency between eventsConsumptionTime and eventsConsumptionTimeTotal. By calling this method we fix the duration as a method variable, and assign the same value to both metrics.
* Metrics description changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within this commit there are 2 metrics implemented:
It will help to monitor the throughput of the transfered cache entries as well as finish time of the proccess.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.