Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-23901 Add operation time performance statistics for putAllConflict, removeAllConflict #11793

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

IGNITE-23901 Add operation time performance statistics for putAllConflict, removeAllConflict #11793

wants to merge 5 commits into from

Conversation

maksaska
Copy link
Contributor

@maksaska maksaska commented Jan 1, 2025 •
edited
Loading

Performance statisitcs tracking added for the following cache operations:

  • #putAllConflict()
  • #removeAllConflict()

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

Maksim Davydov and others added 3 commits January 16, 2025 15:38
@maksaska
IGNITE-23901
b7ff4f8 
* new cache operations for perfstat
* tests
@maksaska
IGNITE-23901
7080fc3 
* test fixed
@maksaska
IGNITE-23901
fcf7e89 
* tests cases separated
@maksaska
IGNITE-23901
629633c 
* tests fixed
oleg-vlsk
oleg-vlsk reviewed Jan 22, 2025
View reviewed changes
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java Outdated Show resolved Hide resolved
...he/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java Outdated Show resolved Hide resolved
...he/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java
* @throws Exception If failed.
*/
@Test
public void testCachePutAllConflict() throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider removing the "Cache" substring from the names of the test methods and checkCacheAllConflictOperations, as it doesn't really provide any additional useful information. This will result in less code and improved readability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the "cache" in naming to match the OperationType. e.g. CACHE_PUT_ALL_CONFLICT
I agree, it can result in less code should we remove it, but I see that it's used throughout the test class. I would prefer to follow that. WDYT?

@maksaska
IGNITE-23901
e6e26e5 
* redundant code fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-vlsk oleg-vlsk oleg-vlsk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maksaska @oleg-vlsk