IGNITE-13190 #7984
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.ignite.configuration; | ||
|
|
||
| import java.io.Serializable; | ||
|
|
||
| /** | ||
| * | ||
| */ | ||
| public final class DefragmentationConfiguration implements Serializable { | ||
| /** Serial version uid. */ | ||
| private static final long serialVersionUID = 0L; | ||
|
|
||
| /** | ||
| * | ||
| */ | ||
| public static final long DFLT_MAPPIN_REGION_SIZE = 256L * 1024 * 1024; | ||
|
|
||
| /** | ||
| * | ||
| */ | ||
| private long regionSize = DataStorageConfiguration.DFLT_DATA_REGION_MAX_SIZE; | ||
|
|
||
| /** | ||
| * | ||
| */ | ||
| private long mappingRegionSize = DFLT_MAPPIN_REGION_SIZE; | ||
|
There was a problem hiding this comment. Can we calculate defragmentation regions automatically? For example, the mapping region size can be calculated as max(size of the cache) * C (we store a link->link mapping, so the region size can be estimated pretty much accurately). If this is something viable, I would move these configuration parameters to system properties so that user does not have to configure anything at all. There was a problem hiding this comment. @akalash will merge similar fix soon. |
||
|
|
||
| /** | ||
| * @return Region size. | ||
| */ | ||
| public long getRegionSize() { | ||
| return regionSize; | ||
| } | ||
|
|
||
| /** | ||
| * @param regionSize | ||
| */ | ||
| public DefragmentationConfiguration setRegionSize(long regionSize) { | ||
| this.regionSize = regionSize; | ||
|
|
||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * @return Mapping region size. | ||
| */ | ||
| public long getMappingRegionSize() { | ||
| return mappingRegionSize; | ||
| } | ||
|
|
||
| /** | ||
| * @param mappingRegionSize | ||
| */ | ||
| public DefragmentationConfiguration setMappingRegionSize(long mappingRegionSize) { | ||
| this.mappingRegionSize = mappingRegionSize; | ||
|
|
||
| return this; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.ignite.internal.processors.cache.persistence.defragmentation; | ||
|
|
||
| import java.util.HashSet; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| /** */ | ||
| public class CacheDefragmentationContext { | ||
| /** */ | ||
|
|
||
| /** */ | ||
| private final Set<Integer> cacheGroupsForDefragmentation; | ||
|
|
||
| /** | ||
| * @param cacheGroupsForDefragmentation Cache group ids for defragmentation. | ||
| */ | ||
| public CacheDefragmentationContext( | ||
| List<Integer> cacheGroupsForDefragmentation | ||
| ) { | ||
|
|
||
| this.cacheGroupsForDefragmentation = new HashSet<>(cacheGroupsForDefragmentation); | ||
| } | ||
|
|
||
| /** */ | ||
| public Set<Integer> cacheGroupsForDefragmentation() { | ||
| return cacheGroupsForDefragmentation; | ||
| } | ||
|
|
||
| /** */ | ||
| public void onCacheGroupDefragmented(int grpId) { | ||
| // Invalidate page stores. | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a dedicated
DefragmentationConfiguration? Can we store all these properties inDataStorageConfiguration?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can, it's a subject for discussion I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest minimizing changes. If the wider defragmentation configuration scope appears we can create a such a class configuration, but currently, I see no reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll try to derive region sizes from current configuration. Not exactly the same way as @agoncharuk described, but approach will be similar. I hope that it won't take much time.